World map

 

BM

World 5: Teamwork · Boss challenge

Team sim: review and merge

You will learn: to review a teammate's PR from red check to merged, kindly.

The problem

Mei asks you to review PR #12: the new events page. Its check shows a red ✗. What do you do first?

Try it

Room 1: open the failing run. Find the step that failed, and read its log.

Practice repo — not a real website
kelab-kod / club-site
CI #31
Failed pull_request on events-page
Tap a step to see its log.
test

Try it

Room 2: review Mei’s PR. Request changes, kindly. Say which link to fix.

Practice repo — not a real website
kelab-kod / club-site
Add events page #12
Open mei wants to merge events-page into main
  1. mei

    Adds the events page with our next events.

    Closes #9

Checks
  • Failed test
Merging this closes #9.
How to merge
Merging is blocked
  • A check failed. This branch needs every check to pass.
  • This branch needs one approving review first.
Your review

Try it

Room 3: Mei pushed a fix, and the check is green. Look at Files changed. Happy? Approve it.

Practice repo — not a real website
kelab-kod / club-site
Add events page #12
Open mei wants to merge events-page into main
  1. mei

    Adds the events page with our next events.

    Closes #9

  2. You asked for changes

    Great page! The sign-up link says signup.htm. Can you make it signup.html?

  3. mei

    Good catch! Fixed the link. The check is green now.

Checks
  • Passed test
Merging this closes #9.
How to merge
Merging is blocked
  • A reviewer asked for changes. Fix those first.
Your review

Try it

Room 4: approved and green. This team squashes every PR. Squash and merge it. Then check issue #9.

Practice repo — not a real website
kelab-kod / club-site
Add events page #12
Open mei wants to merge events-page into main
  1. mei

    Adds the events page with our next events.

    Closes #9

  2. You asked for changes

    Great page! The sign-up link says signup.htm. Can you make it signup.html?

  3. You approved these changes

    Link works now. Lovely page, thanks Mei!

  4. mei

    Good catch! Fixed the link. The check is green now.

Checks
  • Passed test
Merging this closes #9.
How to merge
Merging is blocked
  • This branch keeps history in one straight line. Pick squash or rebase.
Your review

Check

Nobody touched issue #9. Why did it close?

You did it!

You can now review, fix and merge a teammate’s PR like a pro.