World map

 

BM

World 5: Teamwork

Pull requests and drafts

You will learn: how to offer your change with a pull request, and when to use a draft.

The problem

Your fix is ready on your own branch. But main belongs to the whole club. How do you get your change in, politely?

Try it

A pull request (PR): Ask others to review and accept your changes. (PR) says: please pull my branch into main. The team reads it, talks, then merges. Answer Mei’s question.

Practice repo — not a real website
kelab-kod / club-site
Fix the sign-up button #21
Open you wants to merge fix-signup into main
  1. you

    The button pointed to a missing page. Now it opens signup.html.

  2. mei

    Nice! Did you test it on a phone?

Checks
  • Passed test
How to merge
Merging is blocked
  • This branch needs one approving review first.
Your review

Try it

A PR has two main tabs. Where do you find each thing?

Drag a card into a box. Or tap the card, then tap the box.

      Predict

      Your work is half done. You open it as a draft pull request: A pull request marked as not finished. Nobody can merge it until it is ready for review.. Can anyone merge it now?

      Try it

      Your draft is finished now. Aina already approved it. Mark it ready for review, then merge it.

      Practice repo — not a real website
      kelab-kod / club-site
      Add a footer #22
      Draft you wants to merge footer into main
      1. you

        Adds a footer with our meeting time.

      2. Aina approved these changes

        Looks good! Ship it when it is done.

      Checks
      • Passed test
      How to merge
      Merging is blocked
      • This is still a draft. Mark it ready for review first.
      Your review

      Check

      Put a pull request’s life in order. First at the top.

      First step at the top. Put these in order. Use the arrows, or drag.

      • Merge it into main
      • Commit on your own branch
      • Push the branch to GitHub
      • Open a pull request
      • Teammates review it

      You did it!

      You can now open a pull request, and use a draft for unfinished work.

      Go deeper (optional)

      You can turn a PR back into a draft at any time. Drafts do not ask code owners to review. Marking one ready does. You can open PRs on the website, from your editor, or with gh pr create (World 9). A pull request template fills in the description for you.